Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update en_us.json #1236

Closed
wants to merge 5 commits into from
Closed

Conversation

MuteTiefling
Copy link
Contributor

Found a couple grammatical errors that ought to be corrected.

Use "an" instead of "a" when the following word begins with a vowel sound. "An Afrit" instead of "A Afrit"

Fixed some missing capitalization. Generally in the book spirit types are written as proper nouns (Foliot instead of foliot).

For Lime Chalk the title felt out of place compared to the others, so it was made "refreshing" as lime drinks are refreshing.

Orange Chalk title changed. At the very least this would be "Hot Little" not "Little Hot".

Green Chalk title similarly felt out of place, like it couldn't decide. Settled to "Chalk of the Wilds".

Light Blue chalk title changed to Glacial Chalk. Glaced is not a word in English.

Following the "Spirit Summoning" format for summoning rituals, the others are changed to "Spirit Possession" and "Spirit Infusion" for consistency and clarity. In the case of possession, the spirit is possessing the object or creature. As written, it meant the spirit was being possessed by the object or creature.

There are a few more in there for clarity's sake. Feel free to ask if you have any questions on why they were changed.

Found a couple grammatical errors that ought to be corrected.

Use "an" instead of "a" when the following word begins with a vowel sound. "An Afrit" instead of "A Afrit"

Fixed some missing capitalization. Generally in the book spirit types are written as proper nouns (Foliot instead of foliot).

For Lime Chalk the title felt out of place compared to the others, so it was made "refreshing" as lime drinks are refreshing.

Orange Chalk title changed. At the very least this would be "Hot Little" not "Little Hot". 

Green Chalk title similarly felt out of place, like it couldn't decide. Settled to "Chalk of the Wilds".

Light Blue chalk title changed to Glacial Chalk. Glaced is not a word in English. 

Following the "Spirit Summoning" format for summoning rituals, the others are changed to "Spirit Possession" and "Spirit Infusion" for consistency and clarity. In the case of possession, the spirit is possessing the object or creature. As written, it meant the spirit was being possessed by the object or creature. 

There are a few more in there for clarity's sake. Feel free to ask if you have any questions on why they were changed.
@Eqis-Edu
Copy link
Contributor

Thanks, starting to move to datagen so as not to be overwritten

The green is really to convey this feeling of not fitting in, as it is the first chalk outside the main line of progression.

@MuteTiefling
Copy link
Contributor Author

The green is really to convey this feeling of not fitting in, as it is the first chalk outside the main line of progression.

An understandable desire, but the text doesn't read that way. "This, but specifically this other thing entirely" is confusing and contradictory. "Specifically" denotes precision. It is 'exactly' this thing. So presenting another name and immediately changing it just confuses things.

@Eqis-Edu
Copy link
Contributor

I still don't see the confusion, "Nature" is a very big concept and explaining the "Flora" aspect is not contradictory.

@MuteTiefling
Copy link
Contributor Author

MuteTiefling commented Oct 26, 2024

This is X.

No that's a lie. It's actually Y.

It just makes no sense in English and not conveying the meaning you're intending. Just call it what it is the first time.

It's a title in an instruction manual. It should be clear and concise. What benefit or added understanding is there by naming it two different things?

It's a common tendency to write like we speak,and what you've got here is something you'd do in conversation. Start by stating a broad concept, then second guessing yourself and refining what you have to say.

In writing there's no need for that. You're not talking to us. So skip straight to the refined thought. The confusion isn't "I have no idea what you're saying", it's simply that the writing doesn't seem to know what it is saying.

@Eqis-Edu
Copy link
Contributor

Now I get your point, I just put "The Plant Chalk"

@Eqis-Edu Eqis-Edu mentioned this pull request Oct 26, 2024
@klikli-dev
Copy link
Owner

@Eqis-Edu @MuteTiefling are all changes from this PR now in #1237?

@MuteTiefling
Copy link
Contributor Author

MuteTiefling commented Oct 31, 2024

I've left some comments and a review on that one @klikli-dev.

Looks like some writing style mistakes were missed.

Also, I'm questioning the final pentagram's use of nearly (or completely) invisible blocks. This just feels very anti player to me and is going to lead to an endless stream of people who can't complete it.

@klikli-dev klikli-dev reopened this Oct 31, 2024
@klikli-dev
Copy link
Owner

I've left some comments and a review on that one @klikli-dev.

Looks like some writing style mistakes were mixed.

Also, I'm questioning the final pentagram's use of nearly (or completely) invisible blocks. This just feels very anti player to me and is going to lead to an endless stream of people who can't complete it.

I'll leave this one open until we have all cleaned up.

Eqis reported the invisible blocks as a bug on modonomicon which I have to investigate, because that really should not happen. Independent of that we may have to change the recipe in occultism until that is fixed or just find a good alternative fit

@MuteTiefling
Copy link
Contributor Author

Tbh they feel rather out of place and random for an end game pentacle used to summon eldritch beings.

I think there are more thematic blocks that could be used instead.

@klikli-dev
Copy link
Owner

Closing this in favor of #261 to collect the remaining open issues with recent changes there

@klikli-dev
Copy link
Owner

Apparently I did not in fact close it ...

@klikli-dev klikli-dev closed this Dec 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants