Test for Proto Differ to ignore same comments #19
+6
−3
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
There was a problem hiding this comment.
Full Diff
--- xml_converter/integration_tests/test_cases/xml_category_inheritance/output_proto/markers.guildpoint.textproto._old 2025-02-05 01:39:54.069336166 +0000
+++ xml_converter/integration_tests/test_cases/xml_category_inheritance/output_proto/markers.guildpoint.textproto._new 2025-02-05 01:39:54.076336111 +0000
@@ -23,6 +23,14 @@
z: 215.83
}
}
+ icon {
+ map_id: 50
+ position {
+ x: 100.81
+ y: 200.65
+ z: 300.830017
+ }
+ }
id: "(\350\314\006\302\223^\226"
}
category {
There was a problem hiding this comment.
Changing a file to generate a diff. Called File1
klingbolt
force-pushed
the
test_proto_differ_checker
branch
from
e4ada0e to
e25070f
Compare
There was a problem hiding this comment.
Full Diff
--- xml_converter/integration_tests/test_cases/xml_category_name/output_proto/markers.guildpoint.textproto._old 2025-02-05 02:19:19.103009556 +0000
+++ xml_converter/integration_tests/test_cases/xml_category_name/output_proto/markers.guildpoint.textproto._new 2025-02-05 02:19:19.111009642 +0000
@@ -24,5 +24,13 @@
z: 215.83
}
}
+ icon {
+ map_id: 50
+ position {
+ x: 100.81
+ y: 200.65
+ z: 300.830017
+ }
+ }
id: "(\350\314\006\302\223^\226"
}
There was a problem hiding this comment.
Changing a 2nd file. This commit did not generate a diff for File1
There was a problem hiding this comment.
Full Diff
--- xml_converter/integration_tests/test_cases/xml_category_inheritance/output_proto/markers.guildpoint.textproto._old 2025-02-05 02:28:19.965347476 +0000
+++ xml_converter/integration_tests/test_cases/xml_category_inheritance/output_proto/markers.guildpoint.textproto._new 2025-02-05 02:28:19.972347558 +0000
@@ -23,6 +23,14 @@
z: 215.83
}
}
+ icon {
+ map_id: 50
+ position {
+ x: 200.81
+ y: 400.65
+ z: 600.83
+ }
+ }
id: "(\350\314\006\302\223^\226"
}
category {
There was a problem hiding this comment.
Another change to File1 generates a new comment. No comment of File2
There was a problem hiding this comment.
Full Diff
--- xml_converter/integration_tests/test_cases/xml_category_inheritance/output_proto/markers.guildpoint.textproto._old 2025-02-05 02:30:09.035981693 +0000
+++ xml_converter/integration_tests/test_cases/xml_category_inheritance/output_proto/markers.guildpoint.textproto._new 2025-02-05 02:30:09.043981757 +0000
@@ -23,6 +23,14 @@
z: 215.83
}
}
+ icon {
+ map_id: 50
+ position {
+ x: 100.81
+ y: 200.65
+ z: 300.830017
+ }
+ }
id: "(\350\314\006\302\223^\226"
}
category {
There was a problem hiding this comment.
Changing File1 back to first commit generates a new comment. This keeps a record of changes to the file within the same PR.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.