Python3 support added #7
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello,
I was working with your tool yesterday and run into issues due to it not working with Python 3, so I decided to port it to work with newer versions of Python. As it stands, I've tested it with Python 3.8 and Python 3.11 and have reasons to believe it should work with any Python version 3.0 or greater.
I have integrated by work into a different branch since the new version of the tool does not work for Python 2, since there have been major changes in the sockets API that break a lot of the functionality.
I believe that adding Python3 support to the tool is interesting, since Python 3 is now standard and most likely to be present on target machines during pentests, so a Python3 version of the tool can prove useful for professionals in the field.
Nonetheless, I think that it could be interesting to have support for both Python3 and Python2 present in the tool, since it would make it more versatile, and I would be open to working on it if you deem worthwhile. If not, I believe that a Python3 version of the tool can be more relevant in today's environment and it could help foster the popularity of the tool, since it has already been requested in the issues.
I will be waiting for your reply,
Sincerely yours,
CyberScream