Check callback availability in SpdyProxyClientSocket::RunWriteCallback

OnClose() could consume `write_callback_` so it may not be available when RunWriteCallback() is invoked. Bug: 1428820 Change-Id: I9a5ade62d67f5bf15e12d0915d1ad6098657ffd4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4437791 Code-Coverage: Findit <[email protected]> Reviewed-by: Adam Rice <[email protected]> Commit-Queue: Kenichi Ishibashi <[email protected]> Cr-Commit-Position: refs/heads/main@{#1131689}
klzgrad · May 6, 2023 · 2396bbe · 2396bbe
1 parent 900f316
commit 2396bbe
Showing 1 changed file with 4 additions and 3 deletions.
diff --git a/src/net/spdy/spdy_proxy_client_socket.cc b/src/net/spdy/spdy_proxy_client_socket.cc
@@ -277,10 +277,11 @@ int SpdyProxyClientSocket::GetLocalAddress(IPEndPoint* address) const {
 }
 
 void SpdyProxyClientSocket::RunWriteCallback(int result) {
-  CHECK(write_callback_);
-
   base::WeakPtr<SpdyProxyClientSocket> weak_ptr = weak_factory_.GetWeakPtr();
-  std::move(write_callback_).Run(result);
+  // `write_callback_` might be consumed by OnClose().
+  if (write_callback_) {
+    std::move(write_callback_).Run(result);
+  }
   if (!weak_ptr) {
     // `this` was already destroyed while running `write_callback_`. Must
     // return immediately without touching any field member.