Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adds a Global Footer to the website #126

Open
wants to merge 7 commits into
base: main
Choose a base branch
from

Conversation

Murdock9803
Copy link
Contributor

@Murdock9803 Murdock9803 commented Jan 31, 2025

Fixes Issue #112

Description

The Pull request aims to add a Footer at the bottom of the site, which was absent earlier. A footer is important for a site for various purposes like ease of user access, better navigability, and providing a conclusion to the webpage. This PR adds a simple footer for the website, which is responsive to all screen sizes. The footer can also be easily updated for changes in the future.

Screenshots

Before:
image

After:
image

Checklist

  • I have performed a self-review of my code (by locally developing the site).
  • My fork of the repository is updated.
  • The Footer is adaptable to various screen sizes.
  • I have tried to keep the color scheme of the website similar.

@kmesh-bot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign yaozengzeng for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Copy link

netlify bot commented Jan 31, 2025

Deploy Preview for kmesh-net ready!

Name Link
🔨 Latest commit 81bc58a
🔍 Latest deploy log https://app.netlify.com/sites/kmesh-net/deploys/679ca7f1c2881a00089efe31
😎 Deploy Preview https://deploy-preview-126--kmesh-net.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@Murdock9803
Copy link
Contributor Author

@LiZhenCheng9527 I have added a footer for the website, and carefully did the changes. This change does not affect anything else on the site, So we can merge it 🙌
Please have a look 🙌

@jayesh9747
Copy link

@Murdock9803

I've gone through several Kubernetes organizations and noticed some common design patterns. I have a small suggestion regarding the footer section. Currently, the navbar already displays the logo and buttons, and repeating them in footer section might not be necessary. Instead, we could consider displaying only essential elements like social media icons or a "Contact Us" section for better clarity and usability.

Here are some references that might help in refining the design:

Reference 1

Reference 2

Reference 3

You can consider picking one of these designs as inspiration for improvements. as per my opinion first one is good.

Just a humble suggestion—looking forward to your thoughts!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants