Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

perf: Improve website performance and Lighthouse score #129

Open
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

Dhiren-Mhatre
Copy link
Contributor

Description

This PR improves the website's performance score from 42 to 50 by optimizing images and implementing lazy loading in the performance documentation section. These changes align with issue #115's goal of improving the website's usability and documentation readability.

Changes Made

  • Optimized performance test images using lossless compression:
    • perf_network.png
    • fortio_performance_test.png
  • Added lazy loading attributes to images in performance documentation
  • Specified image dimensions to prevent layout shifts

Performance Improvements

  • First Contentful Paint: Reduced from 4.4s
  • Largest Contentful Paint: Reduced from 22.7s
  • Total Blocking Time: Reduced from 590ms
  • Overall Lighthouse Performance Score: Increased from 42 to 50

Testing Done

  • Ran Lighthouse audits before and after changes
  • Verified image quality remains clear and readable
  • Tested lazy loading behavior
  • Confirmed documentation readability is maintained

Related Issue

Part of #115 - Website redesign and implementation

  • Addresses documentation readability improvement
  • Contributes to better developer experience
  • Improves website performance metrics

Screenshots

  • Before:
    Screenshot from 2025-02-03 00-08-56

  • After:

Screenshot from 2025-02-03 00-43-48

  • Even though the "Files Changed" section shows that the image dimensions have changed, the website still loads the images correctly due to its properties.
    Screenshot from 2025-02-03 00-48-13
    image

@kmesh-bot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign lizhencheng9527 for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Copy link

netlify bot commented Feb 2, 2025

Deploy Preview for kmesh-net ready!

Name Link
🔨 Latest commit 9e43379
🔍 Latest deploy log https://app.netlify.com/sites/kmesh-net/deploys/67a32c1566747200081019c0
😎 Deploy Preview https://deploy-preview-129--kmesh-net.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@jayesh9747
Copy link
Contributor

@Dhiren-Mhatre, I think Lighthouse performance depends more on your network speed, internet connection, and browser.

I got around 70% performance, but the results were not reliable. I also have a suggestion: use original images, and Hugo server will optimize them accordingly.

image

@Dhiren-Mhatre
Copy link
Contributor Author

Thank you, @jayesh9747, for your valuable feedback. I'll revert manual image optimizations and let Hugo handle it. I'll keep the lazy loading attributes for performance benefits.

@Dhiren-Mhatre Dhiren-Mhatre force-pushed the Perf/Improve-lighthouse-score-by-lazy-loading branch from efb604b to 9e43379 Compare February 5, 2025 09:14
@kmesh-bot kmesh-bot added size/S and removed size/XS labels Feb 5, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants