Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[LFX-25] 02-Update .gitignore for Docusaurus Migration #151

Open
wants to merge 5 commits into
base: chaneg-theme
Choose a base branch
from

Conversation

jayesh9747
Copy link
Contributor

This PR updates the .gitignore file to align with the transition from Hugo to Docusaurus.

@kmesh-bot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign kevin-wangzefeng for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

.gitignore Outdated
.env.development.local
.env.test.local
.env.production.local
.vscode
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Isn't that a duplicate of line 24?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yes, i will remove.

Signed-off-by: jayesh@9747 <[email protected]>
@LiZhenCheng9527
Copy link
Collaborator

Please signed-off your commits.

@jayesh9747
Copy link
Contributor Author

image
I have already signed off my commits. Should I sign off the last modified README commit?

@kmesh-bot
Copy link
Collaborator

Adding label do-not-merge/contains-merge-commits because PR contains merge commits, which are not allowed in this repository.
Use git rebase to reapply your commits on top of the target branch. Detailed instructions for doing so can be found here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@LiZhenCheng9527
Copy link
Collaborator

Commit sha: 2736bb1, Author: jayesh@9747, Committer: jayesh@9747; The sign-off is missing.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants