Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Set cmake policy CMP0110 explicitly to avoid warnings #12

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

springmeyer
Copy link

@springmeyer springmeyer commented Aug 4, 2022

Using cmake 3.23.3 when building selene from source I see many repeated warnings like:

CMake Warning (dev) in test/CMakeLists.txt:
  Policy CMP0110 is not set: add_test() supports arbitrary characters in test
  names.  Run "cmake --help-policy CMP0110" for policy details.  Use the
  cmake_policy command to set the policy and suppress this warning.

  The following name given to add_test() is invalid if CMP0110 is not set or
  set to OLD:

    `"selene_tests:Image view creation"´

This warning is for project developers.  Use -Wno-dev to suppress it.

The warning is repeated so many times its difficult to make sense of the other cmake output. So I thought it would be worth providing a PR fixing this issue. Happy to amend this change to do it differently, but for me this change allowed the warnings to be silenced.

/cc @kmhofmann

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant