Skip to content
This repository was archived by the owner on Oct 10, 2024. It is now read-only.

Update to Golang 1.21 #331

Merged
merged 1 commit into from
Jan 23, 2024

Conversation

creydr
Copy link
Contributor

@creydr creydr commented Jan 23, 2024

As per title

@knative-prow knative-prow bot added approved Indicates a PR has been approved by an approver from all required OWNERS files. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Jan 23, 2024
@creydr
Copy link
Contributor Author

creydr commented Jan 23, 2024

/cc @pierDipi @Cali0707 @Leo6Leo

@knative-prow knative-prow bot requested review from Cali0707 and Leo6Leo January 23, 2024 08:35
Copy link

codecov bot commented Jan 23, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (28c5232) 78.26% compared to head (43f6fad) 78.26%.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #331   +/-   ##
=======================================
  Coverage   78.26%   78.26%           
=======================================
  Files           5        5           
  Lines          92       92           
=======================================
  Hits           72       72           
  Misses         19       19           
  Partials        1        1           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@pierDipi pierDipi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

@knative-prow knative-prow bot added the lgtm Indicates that a PR is ready to be merged. label Jan 23, 2024
Copy link

knative-prow bot commented Jan 23, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: creydr, pierDipi

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@knative-prow knative-prow bot merged commit 9f0d159 into knative-extensions:main Jan 23, 2024
14 checks passed
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants