fix: node s2i build when node_modules present #1612
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
knative-prow
bot
added
size/XS
matejvasek
requested review from
zroubalik,
lkingland and
lance
and removed request for
vyasgun
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## main #1612 +/- ##
===========================================
+ Coverage 49.55% 63.69% +14.14%
===========================================
Files 80 92 +12
Lines 10760 11600 +840
===========================================
+ Hits 5332 7389 +2057
+ Misses 4964 3540 -1424
- Partials 464 671 +207
Flags with carried forward coverage won't be shown. Click here to find out more.
... and 55 files with indirect coverage changes Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report in Codecov by Sentry. |
matejvasek
force-pushed
the
fix-s2i-node-build-with-node-modules-on-fs
branch
from
e521d72 to
faae74b
Compare
knative-prow
bot
added
size/S
This is workaround for two bug in another components: * The s2i CLI/library is not honoring the `--exclude` flag when used with the `--as-dockerfile` flag. * The node s2i image is not working if project contains `node_modules` directory with NodeJS modules. If only one of the bugs above were fixed this commit wouldn't be necessary. Signed-off-by: Matej Vasek <[email protected]>
matejvasek
force-pushed
the
fix-s2i-node-build-with-node-modules-on-fs
branch
from
faae74b to
a8a36e9
Compare
|
@zroubalik @lkingland PTAL |
Signed-off-by: Matej Vasek <[email protected]>
Signed-off-by: Matej Vasek <[email protected]>
knative-prow
bot
added
size/M
Signed-off-by: Matej Vasek <[email protected]>
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: lkingland, matejvasek The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
🐛 Fix NodeJS s2i build when
node_modulesis present on filesystem.This is workaround for two bug in another components:
--excludeflag when used with the--as-dockerfileflag.The
--excludeflag is not used in--as-dockerfilemode. openshift/source-to-image#1104node_modulesdirectory with NodeJS modules.Run fails when project contains
node_modulesdirectory. sclorg/s2i-nodejs-container#333If only one of the bugs above were fixed this PR wouldn't be necessary.
/kind bug