-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: support windows. #52
Conversation
knightedcodemonkey
commented
Sep 30, 2024
- closes Does not run on windows 10 #48
- updates dependencies.
- drops support for typescript 4 as peer dep
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #52 +/- ##
==========================================
+ Coverage 98.30% 98.32% +0.01%
==========================================
Files 3 3
Lines 413 417 +4
==========================================
+ Hits 406 410 +4
Misses 7 7 ☔ View full report in Codecov by Sentry. |
@knightedcodemonkey Thank you. I updated to v2.0.0-rc.2 and it works as expected in Windows. I also pulled down the main branch and it builds and the tests pass. I appreciate you doing this, as it seems by the commit history that it was a lot of trial and error since you don’t have a Windows dev environment. |
@davidensinger it was painful, but mainly because I wasn't reading the CI output carefully enough. I kept overlooking the |