Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: support windows. #52

Merged
merged 39 commits into from
Oct 1, 2024
Merged

feat: support windows. #52

merged 39 commits into from
Oct 1, 2024

Conversation

knightedcodemonkey
Copy link
Owner

Copy link

codecov bot commented Sep 30, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 98.32%. Comparing base (7aa7a09) to head (0bf2f05).
Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main      #52      +/-   ##
==========================================
+ Coverage   98.30%   98.32%   +0.01%     
==========================================
  Files           3        3              
  Lines         413      417       +4     
==========================================
+ Hits          406      410       +4     
  Misses          7        7              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@knightedcodemonkey knightedcodemonkey merged commit 044308f into main Oct 1, 2024
6 checks passed
@knightedcodemonkey knightedcodemonkey deleted the bananas branch October 1, 2024 00:19
@davidensinger
Copy link

@knightedcodemonkey Thank you. I updated to v2.0.0-rc.2 and it works as expected in Windows. I also pulled down the main branch and it builds and the tests pass. I appreciate you doing this, as it seems by the commit history that it was a lot of trial and error since you don’t have a Windows dev environment.

@knightedcodemonkey
Copy link
Owner Author

@davidensinger it was painful, but mainly because I wasn't reading the CI output carefully enough. I kept overlooking the \r carriage return character in the failed tests. Glad it's working for you.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Does not run on windows 10
2 participants