Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Give the possibility to supply a custom label generator for pie charts #847

Open
wants to merge 2 commits into
base: develop
Choose a base branch
from

Conversation

ggiambo
Copy link
Contributor

@ggiambo ggiambo commented Apr 26, 2024

See #698.

Demo of PieChart02 with labels showing percentage:

Before
immagine

After
immagine

Copy link
Collaborator

@mccartney mccartney left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. This seems reasonable feature to add.

Thanks for the contribution.

@timmolter
Copy link
Member

Thanks for putting in the effort to change the implementation from your previous PR. Can you change the demo to be in the same format at in

DateTimeFormatter cursorXFormatter = DateTimeFormatter.ofPattern("LLL dd");
, i.e.



            x -> startTime.plusDays(x.longValue()).format(cursorXFormatter)

, without needing to define chart.getSeriesMap().values()?

@ggiambo
Copy link
Contributor Author

ggiambo commented Jun 7, 2024

Hi @timmolter
I'm not sure I full understand your request. I guess you want to avoid the call to Chart#getSeriesMap, that is marked for removal, am I right?
In commit 44f6a18 I tried to gather the total without accessing to the whole series map.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants