Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor Code to Address Implementation and Design Smells #885

Open
wants to merge 6 commits into
base: develop
Choose a base branch
from

Conversation

bindumalavika
Copy link

Implementation Smells

1. Extracted Method
Removed duplicate code by applying the Extract Method refactoring technique.
2. Decomposed Conditional Logic
Simplified a complex conditional block by applying the Decompose Conditional refactoring technique.
3. Introduced Explaining Variable
Improved readability and maintainability by introducing explaining variables to clarify complex expressions and reduce cognitive load in the code.

Design Smells

4. Removed Design Smell in CategoryChartBuilder
Refactored the code to create the CategoryChart object within the CategoryChartBuilder class.
5. Moved getBoundsHint Method
Refactored the getBoundsHint method from the ChartTitle class to the Chart class.
6.Extracted Class
Removed unrelated responsibilities from DemoChartsUtil by applying the Extract Class refactoring technique.

@timmolter
Copy link
Member

I will review soon

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants