Adds modules and configuration to produce an ES module bundle. #5
+216
−13
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I'd like to integrate ibankit with a project using ES modules. This PR:
rollup
after runningtsc
.This PR places the ES build alongside the other build artefacts in the.
./lib
folder.This PR is intended to broach the subject. If this PR is welcome, then it may be better to place bundles in a dist folder. There may also be an argument for including a single UMD bundle too, so all possible module systems (or lack thereof) are addressed:
That said, I don't know how to express the location of the UMD module in
package.json
when there's already a set of CommonJS. modules referenced by themain
field (ESM is easy becausemodule
was unused).