Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(organization): assign invitations to members correctly TASK-1600 #5541

Merged
merged 2 commits into from
Feb 20, 2025

Conversation

noliveleger
Copy link
Contributor

📣 Summary

Fixed an issue where invitations were not properly assigned to the correct organization members and ensured that invitations reflect the intended recipient and organization.

📖 Description

An issue caused invitations to be incorrectly assigned, leading to inconsistencies in organization membership management. This fix ensures that invitations are correctly linked to the intended recipients, preventing access errors or misdirected invitations.

💭 Notes

invite property queryset has been optimized to avoid one query per member from the list endpoint.

👀 Preview steps

Bug template:

  1. Create two MMO
  2. From the owner account, invite the owner of the second
  3. 🔴 [on main] notice that in the account of the 2nd owner, the organization member table shows the owner as invited
  4. 🟢 [on PR] notice that in the account of the 2nd owner, the organization member table shows the owner as the owner and active

@noliveleger noliveleger added API Changes related to API endpoints Back end labels Feb 19, 2025
@noliveleger noliveleger self-assigned this Feb 19, 2025
@noliveleger noliveleger marked this pull request as ready for review February 19, 2025 15:38
@noliveleger noliveleger requested a review from jnm as a code owner February 19, 2025 15:38
@noliveleger noliveleger removed the request for review from jnm February 19, 2025 15:39
@noliveleger noliveleger changed the title fix(organization): assign invitations to members correctly fix(organization): assign invitations to members correctly TASK-1600 Feb 19, 2025
Copy link
Contributor

@rajpatel24 rajpatel24 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@noliveleger noliveleger merged commit 9fb0cdb into main Feb 20, 2025
4 checks passed
@noliveleger noliveleger deleted the task-1600-fix-wrong-org-invitation-assignment branch February 20, 2025 08:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
API Changes related to API endpoints Back end
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants