🔥 Hono Image Proxy #348
Open
🔥 Hono Image Proxy #348
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vikiival
requested review from
hassnian,
Jarsen136 and
preschian
as code owners
|
Also if you have any recommendations feel free |
Jarsen136
approved these changes
Mar 13, 2025
preschian
approved these changes
Mar 14, 2025
There was a problem hiding this comment.
- Update lockfile
- Add the service to the CI deployment: deploy.yml#L10
Nit: Should we use custom headers for vendor usage? Just in case we need to track usage by vendor:
curl -H "X-Koda-Vendor: DotWallet" https://url.com
Otherwise, LGTM
hassnian
approved these changes
Mar 14, 2025
Good idea, currently I've deployed a worker for each one |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context
External projects (nova, talisman, would like to use our image gw) since we would like to have some metrics I would use a proxy to meter it