-
Notifications
You must be signed in to change notification settings - Fork 376
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
New Feature: Web parser with pattern for Piers #957
base: Piers
Are you sure you want to change the base?
Conversation
- Update zlib source to version 1.3.1 - Modify CMake configuration to support static library build - Disable example binaries - Update SHA256 checksum
Thanks for all the updates, can you merge the last 3 commits and I'll do a full review in the coming days? |
Once this passes review the last step will be to add a changelog entry and mini version increment (the middle number as its a new feature) in |
f6d9812
to
22486fe
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just some minors but otherwise looks good.
Please remove the windows build script, I must check on whether or not that can go in but no need to hold up this PR.
Outstanding things that need to be done:
- Changelog entry
- Minor version increment in addon.xml.in
- Update to README.md to explain the feature, otherwise users won't know it's there. At least some additions to the examples are required.
22486fe
to
3fbdbeb
Compare
This reverts commit 056c53b.
3fbdbeb
to
d52395e
Compare
Code formatting issues have been fixed. The changelog has been updated, the minor version in addon.xml.in has been incremented, and the README.md has been updated with explanations and examples of the new feature. The Windows build script has also been removed. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nearly there. Thanks for sticking with it.
There should only be 2 commits in this PR. You seem to have both the windows bvuild script and then a revert for it. Both of those commits can just be removed.
- Add WebStreamExtractor class to handle web stream URL extraction - Improve stream URL parsing in StreamUtils - Add CurlUtils for HTTP request handling - Update WebUtils with improved web request functionality - Update documentation and changelog
d52395e
to
463eae8
Compare
Adapts the "Web Parser with Regex #950 " feature, originally developed for the Omega version, to the Piers version.