Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New Feature: Web parser with pattern for Piers #957

Open
wants to merge 4 commits into
base: Piers
Choose a base branch
from

Conversation

alpgul
Copy link

@alpgul alpgul commented Feb 8, 2025

Adapts the "Web Parser with Regex #950 " feature, originally developed for the Omega version, to the Piers version.

- Update zlib source to version 1.3.1
- Modify CMake configuration to support static library build
- Disable example binaries
- Update SHA256 checksum
@alpgul alpgul changed the title Piers web parser with pattern New Feature: Web parser with pattern for Piers Feb 8, 2025
@phunkyfish
Copy link
Member

Thanks for all the updates, can you merge the last 3 commits and I'll do a full review in the coming days?

@phunkyfish
Copy link
Member

Once this passes review the last step will be to add a changelog entry and mini version increment (the middle number as its a new feature) in addon.xml.in so it can be merged and released.

@alpgul alpgul force-pushed the Piers-webParserWithPattern branch from f6d9812 to 22486fe Compare February 14, 2025 14:40
Copy link
Member

@phunkyfish phunkyfish left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just some minors but otherwise looks good.

Please remove the windows build script, I must check on whether or not that can go in but no need to hold up this PR.

Outstanding things that need to be done:

  • Changelog entry
  • Minor version increment in addon.xml.in
  • Update to README.md to explain the feature, otherwise users won't know it's there. At least some additions to the examples are required.

@alpgul alpgul force-pushed the Piers-webParserWithPattern branch from 22486fe to 3fbdbeb Compare February 17, 2025 16:06
@alpgul alpgul force-pushed the Piers-webParserWithPattern branch from 3fbdbeb to d52395e Compare February 17, 2025 16:27
@alpgul
Copy link
Author

alpgul commented Feb 17, 2025

Code formatting issues have been fixed. The changelog has been updated, the minor version in addon.xml.in has been incremented, and the README.md has been updated with explanations and examples of the new feature. The Windows build script has also been removed.

Copy link
Member

@phunkyfish phunkyfish left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nearly there. Thanks for sticking with it.

There should only be 2 commits in this PR. You seem to have both the windows bvuild script and then a revert for it. Both of those commits can just be removed.

- Add WebStreamExtractor class to handle web stream URL extraction
- Improve stream URL parsing in StreamUtils
- Add CurlUtils for HTTP request handling
- Update WebUtils with improved web request functionality
- Update documentation and changelog
@alpgul alpgul force-pushed the Piers-webParserWithPattern branch from d52395e to 463eae8 Compare February 18, 2025 04:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants