Skip to content

Commit

Permalink
Update cran-comments.md
Browse files Browse the repository at this point in the history
  • Loading branch information
koenderks committed Apr 7, 2023
1 parent 916457c commit d362f1f
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion cran-comments.md
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@

This is a resubmission for version 0.6.6. In this version I have:

* Attempted to fix the `clang-UBSAN` error `caster.h:30:25: runtime error: -468 is outside the range of representable values of type 'unsigned int'` while building a vignette by preventing negative values for the `seed` argument in the call to `rstan::sampling`.
* Attempted to fix the `clang-UBSAN` error `caster.h:30:25: runtime error: -468 is outside the range of representable values of type 'unsigned int'` by preventing negative values for the `seed` argument in the call to `rstan::sampling`. There is an open issue on the `rstan` GitHub issue tracker (titled `seed = NA results in a clang-UBSAN error on CRAN`), which discusses the same `clang-UBSAN` error as a result of an `NA` input for the `seed`. Hence, I suspect the root of the problem to be an invalid (negative) value for `rstan`'s seed. I have fixed this in this submission of `jfa`. Would you please be so kind as to test with this fix? If the problem is resolved, I can give the `rstan` team more information regarding negative seed inputs.

## Test environments

Expand Down

0 comments on commit d362f1f

Please sign in to comment.