Add Fuzzy Jacard similarity #43
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Merge branch 'master' into issue-42 # Conflicts: # DESCRIPTION # R/proxy.R # man/simil.Rd # src/pair.cpp
Codecov Report
@@ Coverage Diff @@
## master #43 +/- ##
==========================================
+ Coverage 99.50% 99.51% +0.01%
==========================================
Files 4 4
Lines 401 416 +15
==========================================
+ Hits 399 414 +15
Misses 2 2
... and 2 files with indirect coverage changes 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
rcannood
approved these changes
Oct 22, 2023
There was a problem hiding this comment.
The proposed changes look good!
R CMD check looks good!
Revdepcheck also looks good!
Revdepcheck
> revdepcheck::revdep_check(timeout = as.difftime(600, units = "mins"), num_workers = 30)
── INIT ───────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────── Computing revdeps ──
── INSTALL ───────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────── 2 versions ──
Installing CRAN version of proxyC
also installing the dependencies ‘Rcpp’, ‘RcppParallel’, ‘RcppArmadillo’
Installing DEV version of proxyC
Installing 3 packages: Rcpp, RcppArmadillo, RcppParallel
── CHECK ────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────── 11 packages ──
✔ applicable 0.1.0 ── E: 0 | W: 0 | N: 0
✔ dynutils 1.0.11 ── E: 0 | W: 0 | N: 0
✔ quanteda.textstats 0.96.3 ── E: 0 | W: 0 | N: 1
✔ seededlda 1.1.0 ── E: 0 | W: 0 | N: 4
✔ LSX 1.3.1 ── E: 0 | W: 0 | N: 1
✔ immcp 1.0.3 ── E: 1 | W: 0 | N: 0
✔ scClassify 1.12.0 ── E: 0 | W: 0 | N: 0
✔ scMerge 1.16.0 ── E: 1 | W: 0 | N: 0
✔ SimBu 1.2.0 ── E: 0 | W: 0 | N: 2
✔ simplifyEnrichment 1.10.0 ── E: 0 | W: 0 | N: 1
✔ scFeatures 1.0.0 ── E: 1 | W: 0 | N: 0
OK: 11
BROKEN: 0
Total time: 1 hour
LGTM!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
for #42