Fix deprecation in SampleMain.java #147
Conversation
Displays usage of all of the methods showed in the previous sample.
| return; | ||
| } | ||
|
|
||
| if( arguments.isEmpty() ) | ||
| System.out.println("No args given. Example useage: java SampleMain" + parser.printExample(OptionHandlerFilter.ALL)); |
There was a problem hiding this comment.
This should probably go to System.err, as goes e.printStackTrace()
There was a problem hiding this comment.
Removing the help message on parsing error was a mistake, thanks for correcting that.
The second change depends on whether the program should run given no arguments. However, programs that use args4j will likely require some arguments to run correctly. I agree with this change as well.
| System.err.println(" Example: java SampleMain"+parser.printExample(ALL)); | ||
|
|
||
| } catch (CmdLineException e) { | ||
| e.printStackTrace(); |
There was a problem hiding this comment.
The printing of the help message in case of a CmdLineException (malformed CLI options) is completely lost which was a good example in my humble opinion:
System.err.println(e.getMessage());
System.err.println("java SampleMain [options...] arguments...");
// print the list of available options
parser.printUsage(System.err);
System.err.println();
|
Removing the help message on parsing error was a mistake, thanks for correcting that. The second change depends on whether the program should run given no arguments. However, programs that use args4j will likely require some arguments to run correctly. I agree with this change as well. |
|
Thanks for fixing the deprecations! |
@sfuhrm , this is the updated version of my previous pull request. I had to create a new one because I deleted the repository I used.
I removed
CmdLineExceptionand matched the formatting ofargument.isEmpty()to the other if statements.