Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Swerve #8
base: dev
Are you sure you want to change the base?
Swerve #8
Changes from 12 commits
7896291
63ecb02
026fca4
d0597ba
d7a4746
4f26323
55e9ff4
84b42d5
b39d910
b22c58b
0b6bfe5
ef0b961
663dd0f
8506d05
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Where are the modules? You seem to have a sim setup going on here, just need to convert it over to using the modules to interface with real properly. You can still get the sim working using the modules, you'll just need to make a
SwerveDrivePoseEstimator
object and pass in the data from your modules, which should be handling sim v.s. real on their own. You've got a solid framework here, just need to connect the parts. I'm happy to help you with this tomorrow if you'd likeThere was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please don't use comments, your code already explains itself here