Detect known MPI vendors #136
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cwpearson
force-pushed
the
cmake/mpi-vendor
branch
2 times, most recently
from
0ccf149 to
52b89c2
Compare
dalg24
reviewed
Jan 28, 2025
Sets KOKKOSCOMM_IMPL_MPI_IS_MPICH or KOKKOSCOMM_IMPL_MPI_IS_OPENMPI in cmake and config.hpp depending on whether mpichversion or openmpi_info is next to mpiexec. Signed-off-by: Carl Pearson <[email protected]>
cwpearson
force-pushed
the
cmake/mpi-vendor
branch
from
52b89c2 to
94de2c1
Compare
dssgabriel
previously approved these changes
Jan 28, 2025
devreal
reviewed
Jan 28, 2025
There was a problem hiding this comment.
I think there are more robust ways of figuring out the MPI implementation (like checking for certain macros known to be provided by vendors). That allows more fine-grain distinction between different MPICH flavors (Cray, Intel, vanilla). I guess that depends on what you want to do with this information in the end :)
Co-authored-by: Joseph Schuchart <[email protected]>
|
Yeah I think we can refine this as-needed. Trying to get the basics in place without opening up a multi-hour can of worms before we need to. |
devreal
approved these changes
Jan 28, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Sets
KOKKOSCOMM_MPI_IS_MPICHorKOKKOSCOMM_MPI_IS_OPENMPIin cmake and config.hpp depending on whether mpichversion or openmpi_info is next to mpiexec.We can use this to enable specific tests / workarounds as needed.