Mention oneDPL TPL #496
Merged
Mention oneDPL TPL #496
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dalg24
reviewed
Feb 9, 2024
| @@ -134,6 +134,8 @@ These defines give information about what third-party libaries Kokkos was compil | |||
| +-------------------------------+-----------------------------------------------------------------------------------------------------------------------+ | |||
| | ``KOKKOS_ENABLE_LIBQUADMATH`` | Defined if Kokkos links to the `GCC Quad-Precision Math Library API <https://gcc.gnu.org/onlinedocs/libquadmath/>`_. | | |||
| +-------------------------------+-----------------------------------------------------------------------------------------------------------------------+ | |||
| | ``KOKKOS_ENABLE_ONEDPL`` | Defined if Kokkos links to the `oneDPL library <https://github.com/oneapi-src/oneDPL>`_ when using the SYCL backend. | | |||
| +-------------------------------+-----------------------------------------------------------------------------------------------------------------------+ | |||
There was a problem hiding this comment.
Should we expand to say what it is used for and that things like Kokkos::sort might be less performant if not found?
It is fine if you want to do as a follow up.
There was a problem hiding this comment.
masterleinad
force-pushed
the
document_onedpl
branch
from
3ca94ed to
d02c302
Compare
masterleinad
force-pushed
the
document_onedpl
branch
from
d02c302 to
c2725fe
Compare
dalg24
reviewed
Feb 12, 2024
| @@ -225,6 +225,9 @@ The following options control enabling TPLs: | |||
| * * ``Kokkos_ENABLE_LIBDL`` | |||
| * Whether to enable the LIBDL library | |||
| * ``ON`` | |||
| * * ``Kokkos_ENABLE_ONEDPL`` | |||
| * Whether to enable the oneDPL library | |||
| * ``ON`` | |||
There was a problem hiding this comment.
No language about it being a SYCL-specific TPL?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #494.