Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add documentation about the new CMake keyword: rocthrust #506

Merged
merged 2 commits into from
Mar 11, 2024

Conversation

Rombur
Copy link
Member

@Rombur Rombur commented Mar 11, 2024

Documentation for kokkos/kokkos#6793

dalg24
dalg24 previously approved these changes Mar 11, 2024
@dalg24
Copy link
Member

dalg24 commented Mar 11, 2024

Actually we should document that this is being added in 4.3

@dalg24 dalg24 dismissed their stale review March 11, 2024 15:48

Need to document when support was added

dalg24
dalg24 previously approved these changes Mar 11, 2024
@dalg24 dalg24 dismissed their stale review March 11, 2024 18:14

Doc does not build

@@ -218,16 +218,24 @@ The following options control enabling TPLs:
* -
- Description/info
- Default
- Notes
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/home/runner/work/kokkos-core-wiki/kokkos-core-wiki/docs/source/keywords.rst:213: ERROR: "list-table" widths do not match the number of columns in table (4).

you need to update L214

@dalg24 dalg24 merged commit 5c21bce into kokkos:main Mar 11, 2024
1 check passed
@Rombur Rombur deleted the rocthrust branch March 18, 2024 17:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants