Correct ScatterViews template parameters order #614
Merged
+92
−10
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Also added a small description on how to use ScatterView and added a description for the templates parameters (copied from the cheatsheet one).
| * ``DataType``: | ||
| Works the same as a |View|_'s DataType. | ||
|
|
||
| * ``Layout``: |
There was a problem hiding this comment.
Description regarding Layout.
There was a problem hiding this comment.
I'm not sure of what to write here, I wonder what happens if we pass a Layout (or DataType, or ExecutionSpace) that is different from the one of the underlying view: is it allowed under some circumstances, does it breaks anything ?
This is the main point where I think it would be important to have the opinion of someone familiar with ScatterViews.
tpadioleau
requested changes
Jan 27, 2025
Created hyperlinks to function from usage section Ensured example compile without change Moved Warning about namespace to the top of the file
tpadioleau
approved these changes
Feb 4, 2025
Co-authored-by: Thomas Padioleau <[email protected]>
Co-authored-by: Daniel Arndt <[email protected]>
Co-authored-by: Daniel Arndt <[email protected]>
masterleinad
approved these changes
Feb 27, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Trying to instantiate a ScatterView while specifying its template parameters didn't work as written in the doc.
You can check it here: https://godbolt.org/z/Me1jKezjq
Also added a small description on how to use ScatterView and a description for each template parameter (copied from the cheatsheet).
All of this descriptions may be wrong and need to be checked by someone more familiar with ScatterViews.