Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Spack section #635

Merged
merged 6 commits into from
Mar 12, 2025
Merged

Spack section #635

merged 6 commits into from
Mar 12, 2025

Conversation

cedricchevalier19
Copy link
Member

Try explain:

  • how to compile with Spack
  • how to make a Kokkos dependent package

spack info kokkos


Note that CPU micro-architectures are automatically inherited from Spack's configuration.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't quite understand that sentence.
Does that mean Spack is auto-detecting your CPU arch and passing flags to Kokkos?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, Spack always sets CPU micro-architecture and we follow this setting. It is most likely autoselected, but it can be set by hand, too.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes my understanding spack auto detects it to give a default value to arch. Then the Kokkos recipe does the mapping to the corresponding Kokkos ARCH option.

As @cedricchevalier19 said, if needed you can manually specify arch.

@dalg24 dalg24 requested a review from Rombur February 26, 2025 16:29
Copy link
Member

@tpadioleau tpadioleau left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That looks already good to me. I have a question regarding how far should we go:

  • do we explain other packages like Kokkos Kernels, Kokkos-fft, Kokkos Tools... ? Maybe only Kokkos Tools has some specificity ?
  • I see you mention the develop branch. Maybe we should write the text having spack version 1 in mind ?

Copy link
Member

@tpadioleau tpadioleau left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks almost good to me.

Co-authored-by: Thomas Padioleau <[email protected]>
@dalg24
Copy link
Member

dalg24 commented Mar 12, 2025

Thank you!

@dalg24 dalg24 merged commit 03713d1 into kokkos:main Mar 12, 2025
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants