Remove iterators #302
Merged
Remove iterators #302
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This could be revised later if a more modern version actually implements the feature correctly by checking the version value. Signed-off-by: Luc Berger-Vergiat <[email protected]>
Since the test does not compile on MacOS and it is not really needed we are removing it. See discussion in issue kokkos#300. Signed-off-by: Luc Berger-Vergiat <[email protected]>
crtrott
approved these changes
Jan 30, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Once PR #301 is merge I can rebase this on top of main but for the time being I need both commits to build on my Mac.
Eventually after both PR merge we could look at adding github hosted CI using a MacOS instance to cover this use case.