Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Process Listeners V2 #416

Open
wants to merge 3 commits into
base: develop
Choose a base branch
from

Conversation

Speiger
Copy link

@Speiger Speiger commented Nov 2, 2024

Due to the requests of #413 I am kinda forced to make a new PR.

(Can't switch source branches on an existing PR. At least i don't know of a way)

Now a few changes added.

  • 1: Written in an actual IDE instead of Code spaces... (Compiles now at least)
  • 2: Tests now included and we find out if they work or not. (Never had maven tests run so Github actions help me) Edit: I tested them they are passing on my machine
  • 3: Simple default impl provided with the ProcessListener with the Most likely use case being present.

Hope that this is better :)

Now with a test and a default solution included for easy use.
@Speiger Speiger mentioned this pull request Nov 2, 2024
@Speiger
Copy link
Author

Speiger commented Nov 5, 2024

I have to say, some of these rules you included in code formatting are IMO BS.

Since all these are cosmetic, i picked those that are actually useful changes and made them.
If you need to make changes before you merge, then you can do those, but i think the CodeQuality checker is configured way to picky.

@Speiger
Copy link
Author

Speiger commented Nov 5, 2024

Pr is also complete.
Any changes that need to be done should be done by you at this point.

If that is not possible, please then close the issue.

@Speiger Speiger closed this Nov 9, 2024
@kokorin kokorin reopened this Nov 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants