Villager trading (WIP) #265
Draft
+160
−11
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
looks good 👍 |
|
I know this is wip but a couple suggestions:
|
|
I might just close this because I can't figure out how to fix the errors. Unless anyone else wants to work on it? |
|
I'm 90% sure it's a plugin issue |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Allowing the bot to trade with villagers.
This seems to already be a thing in mineflayer but was not implimented to mindcraft: trader.js from mineflayer repo
added the !trade command (WIP)
added the !showtrades command
added the !showVillagers command.
The trade command sucks right now. Looking into improving it. Currently it does not trade even if it has the resources. If anyone can fix it I would appreciate it but I will look into it soon.