Alter getType to use Type if specified #54
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…tension if no type specified
Codecov Report
@@ Coverage Diff @@
## master #54 +/- ##
==========================================
+ Coverage 34.86% 35.51% +0.65%
==========================================
Files 16 16
Lines 806 808 +2
Branches 185 186 +1
==========================================
+ Hits 281 287 +6
+ Misses 486 479 -7
- Partials 39 42 +3
Continue to review full report at Codecov.
|
kolkov
force-pushed
the
master
branch
7 times, most recently
from
24f5d02 to
bd0c689
Compare
kolkov
force-pushed
the
master
branch
2 times, most recently
from
0884106 to
7c0b04a
Compare
|
I'm also running into the same issue. Would love to see this PR merged! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When using files from cloud storage the URL often comes in a form that is missing a file extension, or has a file extension hidden behind a authentication token etc. This change alters the getType function to respect the Type of the image. If the type of the image is not set then try and detremine the file type from the extension. This changes also adds in .mkv and .3gp file exentsions to video.