Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tag property in KxMenu #6

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Conversation

demetrio812
Copy link

Hello,
I find the tag property useful in order to use a single method for the different actions. I kept the same interface to keep compatibility.

Hopefully you will merge it with the main code.

Thanks,
Dem

@demetrio812
Copy link
Author

Hello, any news on this? Thanks

@hemangshah
Copy link

I'm not sure why the developer ( @kolyvan ) of this beautiful component is not active and not responding to this good change! ~ ~

However to @demetrio812, good change! :)

However I found one more way (without even modifying kxmenu)

in your action,

NSInteger tappedMenuItemIndex = [arrayMenuItems indexOfObject:sender];
if(tappedMenuItemIndex == 1) {
    //...
}

Note, here sender is kxMenuItem.

@demetrio812
Copy link
Author

Thanks @hemangshah, good idea! I thought my change was easy enough to be quickly integrated but anyway :)

@hemangshah
Copy link

@demetrio812 , Your changes is really easy (and understandable too), I appreciated it, but mine is just another solution :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants