Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(KFLUXBUGS-1342): add existing secret in the components secret form #61

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

JoaoPedroPP
Copy link
Contributor

Fixes

KFLUXBUGS-1342

Description

When onboarding a new component and adding a build time secret, the dialog cannot find an existing secret in the workspace.

Copy link

codecov bot commented Jan 6, 2025

Codecov Report

Attention: Patch coverage is 90.32258% with 6 lines in your changes missing coverage. Please review.

Project coverage is 80.09%. Comparing base (4609b37) to head (5ecbdc5).

Files with missing lines Patch % Lines
src/components/Secrets/SecretForm.tsx 80.00% 5 Missing ⚠️
src/components/Secrets/SecretModalLauncher.tsx 50.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main      #61      +/-   ##
==========================================
- Coverage   80.11%   80.09%   -0.02%     
==========================================
  Files         570      570              
  Lines       21452    21476      +24     
  Branches     5050     5326     +276     
==========================================
+ Hits        17187    17202      +15     
- Misses       4241     4249       +8     
- Partials       24       25       +1     
Flag Coverage Δ
unittests 80.09% <90.32%> (-0.02%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@StanislavJochman
Copy link
Contributor

Let me know when you will have it ready. Will pull it and try it out.

@JoaoPedroPP JoaoPedroPP force-pushed the KONFLUX-5921 branch 3 times, most recently from f48167f to b8dafd3 Compare January 13, 2025 11:30
@sahil143
Copy link
Collaborator

/retest

@JoaoPedroPP JoaoPedroPP marked this pull request as ready for review January 13, 2025 17:00
@JoaoPedroPP
Copy link
Contributor Author

Codecov Report

Attention: Patch coverage is 90.32258% with 6 lines in your changes missing coverage. Please review.

Project coverage is 80.13%. Comparing base (1b04567) to head (b8dafd3).

Files with missing lines Patch % Lines
src/components/Secrets/SecretForm.tsx 80.00% 5 Missing ⚠️
src/components/Secrets/SecretModalLauncher.tsx 50.00% 1 Missing ⚠️
Additional details and impacted files

☔ View full report in Codecov by Sentry. 📢 Have feedback on the report? Share it here.

I believe this can be safely ignored

fix: list existing secret in build time secret modal

fix: adjust types in secret form
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants