-
Notifications
You must be signed in to change notification settings - Fork 58
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(RELEASE-1389): update-fbc-catalog need publishingCredentials #794
base: development
Are you sure you want to change the base?
fix(RELEASE-1389): update-fbc-catalog need publishingCredentials #794
Conversation
Skipping CI for Draft Pull Request. |
should be done in the publishing itself to not break stage fbc builds. |
reopening. It can only be done here due to the fact it should interfere wather IIB should be called or not. |
3361cc9
to
bf44073
Compare
/ok-to-test |
tasks/internal/update-fbc-catalog-task/update-fbc-catalog-task.yaml
Outdated
Show resolved
Hide resolved
tasks/internal/update-fbc-catalog-task/update-fbc-catalog-task.yaml
Outdated
Show resolved
Hide resolved
tasks/internal/update-fbc-catalog-task/update-fbc-catalog-task.yaml
Outdated
Show resolved
Hide resolved
this PR adds the publishingCredentials parameter to the update-fbc-catalog pipeline and tasks that is required to fetch the targetIndex config. Signed-off-by: Leandro Mendes <[email protected]>
- text comment - parameter default - using jq -n - README Signed-off-by: Leandro Mendes <[email protected]>
15cec37
to
450e423
Compare
/retest |
1 similar comment
/retest |
Signed-off-by: Leandro Mendes <[email protected]>
@@ -91,6 +91,7 @@ spec: | |||
else | |||
iib_service_account_secret="iib-service-account-prod" | |||
fi | |||
publishing_credentials=$(jq -r '.fbc.publishingCredentials // "catalog-publishing-secret"' "$DATA_FILE") |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is fine, but I think it is kind of weird having the default in both here and the internal pipeline parameter default. The pipeline default won't matter, only this one will, but still a little confusing if they get out of sync. Maybe remove the default in one of the two spots?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The thing is that the default in the other place won't really work without extra work here (checking for null or empty) - if you just remove this default here (which I suggested adding), then you would default to "null". So yeah, I'd just remove the default in the pipeline.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
+1, I think removing from the pipeline is better anyway
@theflockers: The following test has Failed, say /retest to rerun failed tests.
Inspecting Test ArtifactsTo inspect your test artifacts, follow these steps:
mkdir -p oras-artifacts
cd oras-artifacts
oras pull quay.io/konflux-test-storage/konflux-team/release-service-catalog:konflux-e2e-tests-catalog-4lclf Test results analysis🚨 Failed to provision a cluster, see the log for more details: Click to view logsINFO: Log in to your Red Hat account... INFO: Configure AWS Credentials... WARN: The current version (1.2.47) is not up to date with latest rosa cli released version (1.2.49). WARN: It is recommended that you update to the latest version. INFO: Logged in as 'konflux-ci-418295695583' on 'https://api.openshift.com' INFO: Create ROSA with HCP cluster... WARN: The current version (1.2.47) is not up to date with latest rosa cli released version (1.2.49). WARN: It is recommended that you update to the latest version. INFO: Creating cluster 'kx-090314d8d2' INFO: To view a list of clusters and their status, run 'rosa list clusters' INFO: Cluster 'kx-090314d8d2' has been created. INFO: Once the cluster is installed you will need to add an Identity Provider before you can login into the cluster. See 'rosa create idp --help' for more information.
Nodes:
INFO: Preparing to create operator roles. |
this PR adds the publishingCredentials parameter to the update-fbc-catalog pipeline and tasks that is
required to fetch the targetIndex config.
Describe your changes
Relevant Jira
Checklist before requesting a review
do not merge
label if there's a dependency PRrelease-service-maintainers
handle if you are unsure who to tagSigned-off-by: My name <email>