feat(RELEASE-1359): add signing steps to push-artifacts-to-cdn-task #819
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Skipping CI for Draft Pull Request. |
theflockers
force-pushed
the
release-1359
branch
7 times, most recently
from
a347d67 to
5ac4608
Compare
theflockers
force-pushed
the
release-1359
branch
7 times, most recently
from
36e6cd3 to
3b940fb
Compare
These steps were copied and adapted from the `sign-binaries` task. New parameters were added to support signing, many of which have a default that is normally used. Signed-off-by: Martin Malina <[email protected]>
fixes on the task, tests, mocks and hook Signed-off-by: Leandro Mendes <[email protected]>
Signed-off-by: Leandro Mendes <[email protected]>
theflockers
force-pushed
the
release-1359
branch
from
3b940fb to
f4f49c9
Compare
4 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe your changes
This is a follow up PR including the work in progress in the PR #789
Relevant Jira
Checklist before requesting a review
do not mergelabel if there's a dependency PRrelease-service-maintainershandle if you are unsure who to tagSigned-off-by: My name <email>