Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

adding gitlab server to the gitops catalog #46

Merged
merged 9 commits into from
Jan 18, 2024
Merged

adding gitlab server to the gitops catalog #46

merged 9 commits into from
Jan 18, 2024

Conversation

johndietz
Copy link
Contributor

No description provided.

jairoFernandez
jairoFernandez previously approved these changes Jan 17, 2024
View reviewed changes
Copy link
Member

@jairoFernandez jairoFernandez left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, just a question, why this folder in the first level? I mean, if this is the gitops catalog, I expected to see a folder by git provider.... like this in other parts of the application:
...components/argo-github/application.yaml, but here is different 🤔

gitlab/application.yaml Show resolved Hide resolved
CristhianF7
CristhianF7 previously approved these changes Jan 17, 2024
View reviewed changes
@johndietz johndietz dismissed stale reviews from jairoFernandez and CristhianF7 via 541967f January 18, 2024 14:45
@johndietz johndietz merged commit 410358e into main Jan 18, 2024
5 checks passed
@johndietz johndietz deleted the gitlab branch January 18, 2024 14:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jairoFernandez jairoFernandez jairoFernandez left review comments

@CristhianF7 CristhianF7 CristhianF7 left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@johndietz @jairoFernandez @CristhianF7 @fharper