Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix landing page missing #2

Merged
merged 5 commits into from
Dec 11, 2024
Merged

Fix landing page missing #2

merged 5 commits into from
Dec 11, 2024

Conversation

IvanKiral
Copy link
Contributor

Motivation

Which issue does this fix? Fixes #issue number

If no issue exists, what is the fix or new feature? Were there any reasons to fix/implement things that are not obvious?

Checklist

  • Code follows coding conventions held in this repo
  • Automated tests have been added
  • Tests are passing
  • Docs have been updated (if applicable)
  • Temporary settings (e.g. variables used during development and testing) have been reverted to defaults

How to test

If manual testing is required, what are the steps?

Copy link

vercel bot commented Dec 11, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
kickstart ✅ Ready (Inspect) Visit Preview 💬 Add feedback Dec 11, 2024 7:27pm
kickstart-consulting ✅ Ready (Inspect) Visit Preview 💬 Add feedback Dec 11, 2024 7:27pm
kickstart-custed ✅ Ready (Inspect) Visit Preview 💬 Add feedback Dec 11, 2024 7:27pm
kickstart-qa ✅ Ready (Inspect) Visit Preview 💬 Add feedback Dec 11, 2024 7:27pm

<p className={`text-balance font-sans text-xl text-gray ${props.errorMessageClassName ?? ""}`}>
Missing or invalid element codename{" "}
<KontentComponentErrorMessage errorMessageClassName={props.errorMessageClassName}>
Missing element with the codename{" "}
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

two spaces intentional here?

>
Landing Page content type
</a>{" "}
contains elements with elements names and{" "}
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

i would leave just contains elements with names and codenames. if you insist on leaving the duplicit elements in there, it should be contains elements with element names and codenames

@IvanKiral IvanKiral merged commit 33b1067 into main Dec 11, 2024
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants