Merge pull request #14 from kontenta/emptyadminlink

Don't print href if url is empty

src/AdminLink.php

@@ -21,7 +21,7 @@ public function __construct(string $url, string $name, string $description = nul
         $this->description = $description;
     }
 
-    public function getUrl(): string
+    public function getUrl(): ?string
     {
         return $this->url;
     }
@@ -38,11 +38,16 @@ public function getDescription(): ?string
 
     public function toHtml(): string
     {
-        $attributes[] = 'href="' . htmlspecialchars($this->getUrl()) . '"';
+        $attributes = [];
+
+        if ($this->getUrl()) {
+            $attributes[] = 'href="' . htmlspecialchars($this->getUrl()) . '"';
+        }
+
         if ($this->getDescription()) {
             $attributes[] = 'title="' . htmlspecialchars($this->getDescription()) . '"';
         }
 
-        return '<a '.implode(' ', $attributes).'>'.$this->getName().'</a>';
+        return '<a ' . implode(' ', $attributes) . '>' . $this->getName() . '</a>';
     }
 }

src/RouteAdminLink.php

@@ -2,6 +2,9 @@
 
 namespace Kontenta\KontourSupport;
 
+use Illuminate\Support\Facades\Route;
+use Illuminate\Support\Facades\URL;
+
 class RouteAdminLink extends AdminLink
 {
     protected $routeName;
@@ -13,8 +16,8 @@ public function __construct(string $routeName, string $name, string $description
         $this->description = $description;
     }
 
-    public function getUrl(): string
+    public function getUrl(): ?string
     {
-        return route($this->routeName);
+        return Route::has($this->routeName) ? URL::route($this->routeName) : null;
     }
 }

tests/Feature/RouteAdminLinkTest.php

@@ -0,0 +1,17 @@
+<?php
+
+namespace Kontenta\KontourSupport\Tests\Feature;
+
+use Kontenta\KontourSupport\RouteAdminLink;
+use Kontenta\KontourSupport\Tests\IntegrationTest;
+
+class RouteAdminLinkTest extends IntegrationTest
+{
+    public function test_url_is_null_when_route_does_not_exist()
+    {
+        $link = new RouteAdminLink('not.existing', 'Hej', '"Hejsanhejsan"');
+
+        $this->assertNull($link->getUrl());
+        $this->assertEquals('<a title="&quot;Hejsanhejsan&quot;">Hej</a>', $link->toHtml());
+    }
+}