Bugfix/issue 4 #5
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Use failOnSeverity instead of failOnViolations/severity
… failure This works as expected: Introducing an import from business to facade is forbidden and leads to an architecture violation exception
Moving the classes to sub-packages makes the error disappear though this might still be treated as architecture violation.
to solve the issue: - Mark top level Packages (as described in PlantUML) as "SubComponent" - Compute the dependencies between SubComponents - Find SubComponents dependencies which are not enabled by either PlantUML or TechnicalDebt Current implementation (or jQA!?) still has a problem: The concept "AddTransitiveSubComponentDependencies" does not work when the Maven plugin is executed (returns empty set) but works when the query is executed manually
requires reference to built-in "dependency:Package" concept
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
My completely different approach to tackle the problem as discussed per PMs with @jensnerche and @DirkMahler.