Бессараб Дмитрий #259
Open
Бессараб Дмитрий #259
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Pasha0666
reviewed
Nov 16, 2024
Comment on lines
24
to
25
| if (!next.Equals(current)) | ||
| { |
Comment on lines
12
to
14
| [TestFixture] | ||
| public class ArchemedianSpiral_Should | ||
| { |
There was a problem hiding this comment.
Можно еще тест что центр это первая точка
Comment on lines
20
to
22
| if (center.X > 0 && center.Y > 0) | ||
| Center = center; | ||
| else throw new ArgumentException("Center coordinates values have to be greater than Zero"); |
There was a problem hiding this comment.
лучше заминить условие на провиположное и тогда не нужно будет писать else
Comment on lines
54
to
60
| if (Rectangles.Count == 0) | ||
| { | ||
| var firstRectangle = new Rectangle(new Point(Center.X - rectangleSize.Width / 2, | ||
| Center.Y - rectangleSize.Height / 2), rectangleSize); | ||
| Rectangles.Add(firstRectangle); | ||
| return firstRectangle; | ||
| } |
There was a problem hiding this comment.
А зачем выделяем отдельно обработку первого прямоугольника?
TagsCloudVisualization/Drawings.cs
Outdated
Comment on lines
15
to
47
| var rectangleSizes = new RandomSizeRectangle(). | ||
| GenerateRectangles(300); | ||
| var layout = new CircularCloudLayouter(new Point(1000, 1000)); | ||
| var image = new Bitmap(layout.Size.Width, layout.Size.Height); | ||
| foreach (var size in rectangleSizes) | ||
| { | ||
| DrawRectangle(image, layout.PutNextRectangle(size)); | ||
| image.Save(@"c:\\Images\\1.bmp"); | ||
| } | ||
|
|
||
|
|
||
| rectangleSizes = new RandomSizeRectangle(). | ||
| GenerateRectangles(300); | ||
| var points = new HeartShaped().GeneratePoints(new Point(1000, 1000)); | ||
| layout = new CircularCloudLayouter(new Point(1000, 1000), points); | ||
| image = new Bitmap(layout.Size.Width, layout.Size.Height); | ||
| foreach (var size in rectangleSizes) | ||
| { | ||
| DrawRectangle(image, layout.PutNextRectangle(size)); | ||
| image.Save(@"c:\\Images\\2.bmp"); | ||
| } | ||
|
|
||
| rectangleSizes = new RandomSizeRectangle(). | ||
| GenerateRectangles(300); | ||
| //points = new DeltaSHaped().GeneratePoints(new Point(1000, 1000)); | ||
| layout = new CircularCloudLayouter(new Point(1000, 1000), new DeltaSHaped().GeneratePoints); | ||
| image = new Bitmap(layout.Size.Width, layout.Size.Height); | ||
| foreach (var size in rectangleSizes) | ||
| { | ||
| DrawRectangle(image, layout.PutNextRectangle(size)); | ||
| image.Save(@"c:\\Images\\3.bmp"); | ||
| } | ||
| } |
There was a problem hiding this comment.
Вижу копирование, а отличие толкьо точками на вход и путем до изображения
Comment on lines
10
to
13
| namespace TagsCloudVisualization | ||
| { | ||
| [TestFixture] | ||
| public class ArchemedianSpiral_Should |
There was a problem hiding this comment.
Тесты желательно уносить в отдельную сборку
TagsCloudVisualization/Drawings.cs
Outdated
Comment on lines
33
to
34
| DrawRectangle(image, layout.PutNextRectangle(size)); | ||
| image.Save(@"c:\\Images\\2.bmp"); |
There was a problem hiding this comment.
лучше задавать относительне пути от запуска. Допустим не у всех есть диск c
Comment on lines
24
to
42
| Rectangles = []; | ||
| _points = new ArchemedianSpiral().GeneratePoints(Center); | ||
| } | ||
|
|
||
| public CircularCloudLayouter(Point center, IEnumerable<Point> points) : this(center) | ||
| { | ||
| Center = center; | ||
| Size = CountSize(center); | ||
| Rectangles = []; | ||
| _points = points; | ||
| } | ||
|
|
||
| public CircularCloudLayouter(Point center, Func<Point, IEnumerable<Point>> pointGenerator) : this(center) | ||
| { | ||
| Center = center; | ||
| Size = CountSize(center); | ||
| Rectangles = []; | ||
| _points = pointGenerator(Center); | ||
| } |
There was a problem hiding this comment.
Кажется получилось много дублирующи конструкторов
Comment on lines
35
to
37
|
|
||
| public CircularCloudLayouter(Point center, Func<Point, IEnumerable<Point>> pointGenerator) : this(center) | ||
| { |
There was a problem hiding this comment.
Почему на вход не интерфейс IPointGenerator принимаешь?
Pasha0666
reviewed
Nov 16, 2024
Comment on lines
76
to
77
| return others.Select(x => x.IntersectsWith(supposed)) | ||
| .Any(x => x == true); |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@PashaSoldatov (https://t.me/PashaSoldatov)