🐛 set up locks more correctly (#635)

Signed-off-by: Shawn Hurley <[email protected]>
konveyor · Feb 10, 2025 · 41b33f2 · 41b33f2
1 parent 5945e60
commit 41b33f2
Showing 1 changed file with 6 additions and 2 deletions.
diff --git a/kai_analyzer_rpc/pkg/service/analyzer.go b/kai_analyzer_rpc/pkg/service/analyzer.go
@@ -285,10 +285,10 @@ func (a *Analyzer) Analyze(args Args, response *Response) error {
 
 func (a *Analyzer) setCache(rulesets []konveyor.RuleSet) {
 	a.cacheMutex.Lock()
+	defer a.cacheMutex.Unlock()
 	a.cache = map[string][]cacheValue{}
-	a.cacheMutex.Unlock()
 
-	a.updateCache(rulesets, nil)
+	a.addRulesetsToCache(rulesets)
 }
 
 func (a *Analyzer) updateCache(rulesets []konveyor.RuleSet, includedPaths []string) {
@@ -297,6 +297,10 @@ func (a *Analyzer) updateCache(rulesets []konveyor.RuleSet, includedPaths []stri
 	if includedPaths != nil {
 		a.invalidateCachePerFile(includedPaths)
 	}
+	a.addRulesetsToCache(rulesets)
+}
+
+func (a *Analyzer) addRulesetsToCache(rulesets []konveyor.RuleSet) {
 
 	for _, r := range rulesets {
 		for violationName, v := range r.Violations {