✨ Maven Validator now properly detects and reports build errors #486
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fabianvf
commented
Nov 14, 2024
| @@ -14,6 +14,8 @@ | |||
| from kai.reactive_codeplanner.task_runner.compiler.maven_validator import ( | |||
| AccessControlError, | |||
| AnnotationError, | |||
| BuildError, | |||
| DependencyResolutionError, | |||
There was a problem hiding this comment.
@shawn-hurley Should this be handled in the dependency resolution instead? This is the error it's detecting:
[INFO] Scanning for projects...
[INFO]
[INFO] -------------------< com.redhat.coolstore:monolith >--------------------
[INFO] Building coolstore-monolith 1.0.0-SNAPSHOT
[INFO] from pom.xml
[INFO] --------------------------------[ jar ]---------------------------------
Downloading from github: https://maven.pkg.github.com/shawn-hurley/analyzer-lsp/jakarta/jakarta.jakartaee-web-api/8.0.0/jakarta.jakartaee-web-api-8.0.0.pom
Downloading from github: https://maven.pkg.github.com/shawn-hurley/analyzer-lsp/jakarta/jakarta.jakartaee-api/8.0.0/jakarta.jakartaee-api-8.0.0.pom
[INFO] ------------------------------------------------------------------------
[INFO] BUILD FAILURE
[INFO] ------------------------------------------------------------------------
[INFO] Total time: 4.749 s
[INFO] Finished at: 2024-11-13T20:07:09-05:00
[INFO] ------------------------------------------------------------------------
[ERROR] Failed to execute goal on project monolith: Could not resolve dependencies for project com.redhat.coolstore:monolith:jar:1.0.0-SNAPSHOT: Failed to collect dependencies at jakarta:jakarta.jakartaee-web-api:jar:8.0.0: Failed to read artif
act descriptor for jakarta:jakarta.jakartaee-web-api:jar:8.0.0: The following artifacts could not be resolved: jakarta:jakarta.jakartaee-web-api:pom:8.0.0 (absent): Could not transfer artifact jakarta:jakarta.jakartaee-web-api:pom:8.0.0 from/to
github (https://maven.pkg.github.com/shawn-hurley/analyzer-lsp): status code: 401, reason phrase: Unauthorized (401) -> [Help 1]
[ERROR]
[ERROR] To see the full stack trace of the errors, re-run Maven with the -e switch.
[ERROR] Re-run Maven using the -X switch to enable full debug logging.
[ERROR]
[ERROR] For more information about the errors and possible solutions, please read the following articles:
[ERROR] [Help 1] http://cwiki.apache.org/confluence/display/MAVEN/DependencyResolutionExceptionThere was a problem hiding this comment.
Neither of them seem capable of solving the issue at the moment
There was a problem hiding this comment.
How is it writing my github into the maven package? what is happening!
In all seriousness, the FQDN agent should be able to solve this with some tweaking, which may be worth looking into.
- Introduces two new error types, `BuildError` and `DependencyResolutionError`, which are now detected and parsed - Adds a catchall condition if maven exits non-zero but no errors are successfully parsed so that we have a chance at solving the issue - Restructures the maven_validator as the parsing logic was getting unwieldy - The maven task_runner no longer adds whitespace at the top of files - The dependency task_runner now properly checks the tasks it can handle - Adds tests for maven validator Signed-off-by: Fabian von Feilitzsch <[email protected]>
fabianvf
force-pushed
the
maven-build-errors
branch
from
d8470b8 to
1df0a7e
Compare
Signed-off-by: Fabian von Feilitzsch <[email protected]>
pranavgaikwad
approved these changes
Nov 14, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
BuildErrorandDependencyResolutionError, which are now detected and parsed