🐛 Fix dependency agent back and forth chat for not-so-good models #490
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fabianvf
approved these changes
Nov 14, 2024
There was a problem hiding this comment.
I think this makes sense, @shawn-hurley is more familiar with this agent though.
LGTM
shawn-hurley
approved these changes
Nov 14, 2024
| @@ -88,7 +88,7 @@ def execute_task(self, rcm: RepoContextManager, task: Task) -> TaskResult: | |||
| ) | |||
| pom = os.path.join(os.path.join(rcm.project_root, "pom.xml")) | |||
| # Needed to remove ns0: | |||
| ET.register_namespace("", "http://maven.apache.org/POM/4.0.0") | |||
| # ET.register_namespace("", "http://maven.apache.org/POM/4.0.0") | |||
There was a problem hiding this comment.
Lets just remove this ?
Signed-off-by: Pranav Gaikwad <[email protected]>
Signed-off-by: Pranav Gaikwad <[email protected]>
Signed-off-by: Pranav Gaikwad <[email protected]>
|
I am testing this again today with full flow because I was seeing pom.xml issues with white spaces. I have Fabians changes checked out now. |
| # We do not believe that we should not continue now we have to continue after running the code that is asked to be run. | ||
| # The only exception to this rule, is when we actually update the file, that should be handled by the caller. | ||
| # This happens sometimes that the LLM will stop and wait for more information. | ||
| # we have to keep the chat going until we get a final answer |
There was a problem hiding this comment.
should we have some limit here, say 5-8 round trips? if it is more, then something is not correct, and we need to exit?
There was a problem hiding this comment.
I set the limit to 3 but can increase
shawn-hurley
approved these changes
Nov 15, 2024
Signed-off-by: Pranav Gaikwad <[email protected]>
|
Good to merge now |
|
Will merge first thing monday as I assume most folks are done for the weekend |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I think we can simplify the agent a lot because effectively only one of the tools is actually being used but we describe 4 tools in the prompt. But I didn't want to introduce new issues because of it, so I want to take the time to redo / simplify the agent.