generated from konveyor-ecosystem/template-repo
-
Notifications
You must be signed in to change notification settings - Fork 38
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
✨ Added preliminary noisy notifications #596
Merged
JonahSussman
merged 11 commits into
konveyor:main
from
JonahSussman:feature/noisy-notifications
Feb 4, 2025
Merged
✨ Added preliminary noisy notifications #596
JonahSussman
merged 11 commits into
konveyor:main
from
JonahSussman:feature/noisy-notifications
Feb 4, 2025
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
226e7b1
to
22194df
Compare
This was referenced Jan 29, 2025
Signed-off-by: JonahSussman <[email protected]>
Signed-off-by: JonahSussman <[email protected]>
Signed-off-by: JonahSussman <[email protected]>
Signed-off-by: JonahSussman <[email protected]>
Signed-off-by: JonahSussman <[email protected]>
Signed-off-by: JonahSussman <[email protected]>
Signed-off-by: JonahSussman <[email protected]>
33cca90
to
2effeca
Compare
Signed-off-by: Pranav Gaikwad <[email protected]>
Signed-off-by: Pranav Gaikwad <[email protected]>
Signed-off-by: JonahSussman <[email protected]>
pranavgaikwad
requested changes
Feb 4, 2025
example/run_demo.py
Outdated
@@ -93,6 +93,16 @@ def initialize_rpc_server( | |||
log.info(rpc_subprocess.args) | |||
|
|||
app = KaiRpcApplication() | |||
log.setLevel(TRACE) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
is this needed?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nope, this was just for testing. Removing.
Signed-off-by: JonahSussman <[email protected]>
pranavgaikwad
approved these changes
Feb 4, 2025
JonahSussman
added a commit
to konveyor/editor-extensions
that referenced
this pull request
Feb 4, 2025
Ref: konveyor/kai#596 --------- Signed-off-by: JonahSussman <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.