Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

✨ Added preliminary noisy notifications #596

Merged
merged 11 commits into from
Feb 4, 2025

Conversation

JonahSussman
Copy link
Contributor

No description provided.

Signed-off-by: JonahSussman <[email protected]>
Signed-off-by: JonahSussman <[email protected]>
Signed-off-by: JonahSussman <[email protected]>
Signed-off-by: JonahSussman <[email protected]>
Signed-off-by: JonahSussman <[email protected]>
@JonahSussman JonahSussman force-pushed the feature/noisy-notifications branch from 33cca90 to 2effeca Compare January 30, 2025 17:44
pranavgaikwad and others added 3 commits January 31, 2025 16:38
Signed-off-by: Pranav Gaikwad <[email protected]>
Signed-off-by: Pranav Gaikwad <[email protected]>
Signed-off-by: JonahSussman <[email protected]>
@@ -93,6 +93,16 @@ def initialize_rpc_server(
log.info(rpc_subprocess.args)

app = KaiRpcApplication()
log.setLevel(TRACE)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

is this needed?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nope, this was just for testing. Removing.

Signed-off-by: JonahSussman <[email protected]>
@JonahSussman JonahSussman merged commit 5787ea8 into konveyor:main Feb 4, 2025
13 checks passed
JonahSussman added a commit to konveyor/editor-extensions that referenced this pull request Feb 4, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants