✨ package/symbol not found errors are now collapsable for file #615
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
shawn-hurley
commented
Feb 4, 2025
shawn-hurley
commented
- This also adds the clean option to maven, so that maven is recompiled every time; this is needed when the pom.xml does not yet have the maven compiler plugin.
- The line numbers are not used in the dependency agent; because of this, we can assume we know that we don't need to pass it through.
* This also adds the clean option to maven, so that maven is recompiled everytime, this is needed when the pom.xml does not yet have the maven compiler plugin. * The lines numbers are not used in the dependency agent, because of this we can assume we know that we don't need to pass it through. Signed-off-by: Shawn Hurley <[email protected]>
Signed-off-by: Shawn Hurley <[email protected]>
|
@shawn-hurley can we add the line number thing back to cache again? |
|
Debating if we need to add the line number back after this change |
Signed-off-by: Shawn Hurley <[email protected]>
|
After discussing with @pranavgaikwad offline, we think the cache should work just fine in the current paradigm without line numbers because of the collapsibility of tasks and the addition of violation ID to the cache path. |
pranavgaikwad
approved these changes
Feb 4, 2025
shawn-hurley
commented
Feb 5, 2025
shawn-hurley
commented
Feb 5, 2025
shawn-hurley
commented
Feb 5, 2025
| @@ -43,7 +43,7 @@ dependencies = [ | |||
| "lxml==5.3.0", | |||
| "boto3==1.36.9", # Allows Amazon Bedrock to work | |||
| "pylspclient==0.1.2", # used for talking to RPC clients over stdin/stdout | |||
| "opentelemetry-sdk", | |||
| "opentelemetry-sdk==1.29.0", | |||
There was a problem hiding this comment.
This is needed now, because 1.30 breaks mypy
shawn-hurley
commented
Feb 5, 2025
kai/reactive_codeplanner/task_runner/compiler/maven_validator.py
Outdated
Show resolved
Hide resolved
* Remove file from collapsable key for packages because they work across the project * Add the ability to get the compiler message from the task for maven compiler errors, so that a individual error can define it's own message * fixed up the prompt from dependnecy agent to handle new message * added try around spliting lines of code in maven compiler agent becuase sometimes the files are rewritten very poorly Signed-off-by: Shawn Hurley <[email protected]>
shawn-hurley
force-pushed
the
feature/maven-validator-collapsable-errors
branch
from
b4e3f81 to
5f40880
Compare
JonahSussman
approved these changes
Feb 5, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.