Fix Windows installation #152
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Bruno Borges <[email protected]>
joe-braley
reviewed
Feb 9, 2024
| @@ -49,8 +49,8 @@ podman pull quay.io/konveyor/kantra:latest && podman run --name kantra-download | |||
|
|
|||
| ### Windows | |||
|
|
|||
| ```sh | |||
| podman pull quay.io/konveyor/kantra:latest && podman run --name kantra-download quay.io/konveyor/kantra:latest 1> /dev/null 2> /dev/null && podman cp kantra-download:/usr/local/bin/windows-kantra kantra && podman rm kantra-download | |||
| ```powershell | |||
There was a problem hiding this comment.
&& is legal in cmd.exe but not in PowerShell.
Rather, in powershell, it would be:
podman pull quay.io/konveyor/kantra:latest ; podman run --name kantra-download quay.io/konveyor/kantra:latest ; podman cp kantra-download:/usr/local/bin/windows-kantra kantra.exe ; podman rm kantra-download
There was a problem hiding this comment.
@brunoborges Could you update this and we can get it merged. Thanks!
There was a problem hiding this comment.
&& is valid in PowerShell Core (pwsh, "modern" PowerShell), but not Windows PowerShell, in case this helps explain what's going on here.
; is a reasonable compromise for compatibility, although:
- It won't stop when a command fails. This can make things a bit confusing if someone reads the logs from the bottom up after a failure.
- It doesn't work with cmd. If it's made clear in the rendered readme that this is for PowerShell and not cmd (and perhaps also provide a one liner for cmd?), maybe that's fine.
I don't know of a good, universal solution, unfortunately.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.