Run providers in separate container #194
Conversation
eemcmullan
changed the title
eemcmullan
force-pushed
the
prov-container
branch
3 times, most recently
from
6e2eebe
to
520e91f
Compare
eemcmullan
changed the title
eemcmullan
force-pushed
the
prov-container
branch
4 times, most recently
from
775f018
to
3ed679a
Compare
Signed-off-by: Emily McMullan <[email protected]>
eemcmullan
force-pushed
the
prov-container
branch
from
3ed679a
to
37b895e
Compare
|
|
||
| func (a *analyzeCommand) RunProviders(ctx context.Context, networkName string, volName string, providers []string) (map[string]int, error) { | ||
| providerPorts := map[string]int{} | ||
| port, err := freeport.GetFreePort() |
There was a problem hiding this comment.
is free port working on the host network but it probably needs to work on container network?
This is more of a question
There was a problem hiding this comment.
Good point. I'm trying to think of a way around this. The provider container needs the port as it starts, so we would not be able to first run the provider and then check if a port is in use for that container. And I think we moved away from hard-coding in the ports. My only other thought would be to catch the error and try to run the container again.
There was a problem hiding this comment.
I think that may make sense, I was hoping that you could point Freeport to a specific network, but catch err is probably the best approach for now
| @@ -20,8 +20,9 @@ import ( | |||
| type container struct { | |||
| stdout []io.Writer | |||
| stderr []io.Writer | |||
| name string | |||
| Name string | |||
There was a problem hiding this comment.
It is how the analyzer engine connects to the provider's network when the analyzer container is first created. I think the network connect command requires the container to already be running, which I think may complicate things, since the analyzer container needs to start after the provider container.
eemcmullan
force-pushed
the
prov-container
branch
from
0cb1ab5
to
316e44e
Compare
Signed-off-by: Emily McMullan <[email protected]> update settings with provider images Signed-off-by: Emily McMullan <[email protected]>
eemcmullan
force-pushed
the
prov-container
branch
from
316e44e
to
e2f483e
Compare
|
Except for the Freeport part /LGTM |
Signed-off-by: Emily McMullan <[email protected]>
eemcmullan
force-pushed
the
prov-container
branch
from
3cc9870
to
92a6d00
Compare
This will need to be updated for multiple provider containers once we accept multiple inputs
Closes #190