Add NodeJS and Python providers #218
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
shawn-hurley
reviewed
May 2, 2024
| if !a.analyzeKnownLibraries { | ||
|
|
||
| // python and node providers do not yet support dep analysis | ||
| if !a.analyzeKnownLibraries && (providers[0] != pythonProvider && providers[0] != nodeJSProvider) { |
There was a problem hiding this comment.
We eventually need to not hard code this but be able to tell from the provider caps IMO
There was a problem hiding this comment.
there is nothing to do right now, but something to consider in the future that I didn't want to lose track off
There was a problem hiding this comment.
|
I am wondering if this can be used for the .m2 cache for the Java providers as well. |
|
Overall it looks good, the only big concern is that the python/nodejs servers also still need to have the ability to pull the deps down while initing but that should be solved in those providers. I wonder if we call it dependency-cache-folder or something similar, the idea being that the underlying thing may add to this? |
shawn-hurley
approved these changes
May 3, 2024
pranavgaikwad
requested changes
May 6, 2024
Signed-off-by: Emily McMullan <[email protected]>
pranavgaikwad
approved these changes
May 20, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #202