Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

✨ adding override provider settings flag #221

Conversation

shawn-hurley
Copy link
Contributor

@shawn-hurley shawn-hurley commented May 3, 2024

Closes #220
basically if you use the host DNS name in a provider settings like:

[
    {
        "name": "aws",
        "address": "host.containers.internal:10000",
        "initConfig": [
            {
                "location": "shurley-test",
            },
        ],
    },
]

notes:

This allows for non-input analysis, which makes sense because location and things must be described in the provider settings. This means we have to turn off the required flag.

@shawn-hurley shawn-hurley force-pushed the feature/add-provider-settings-override branch from 2b70415 to d5cf003 Compare May 3, 2024 17:59
cmd/analyze.go Outdated Show resolved Hide resolved
}

a.enableDefaultRulesets = false
if a.enableDefaultRulesets {
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Would we also want to check which provider is being used? As right now, the default rulesets are only Java rules.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this is another case where the user has to know which options to set for their providers.

I can see that we probably need to have some more docs, I wonder if this is necessary as we do your work. Can we do a follow-up that lays out a lot of these caveats when using this override setting?

cmd/analyze.go Show resolved Hide resolved
cmd/analyze.go Show resolved Hide resolved
cmd/analyze.go Outdated Show resolved Hide resolved
@shawn-hurley shawn-hurley force-pushed the feature/add-provider-settings-override branch from d5cf003 to 0489c27 Compare June 4, 2024 13:53
Copy link
Collaborator

@eemcmullan eemcmullan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@shawn-hurley shawn-hurley merged commit a89ffa3 into konveyor:main Jun 12, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Ability to use custom providers
2 participants