Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix removing provider container error #235

Merged
merged 1 commit into from
May 21, 2024
Merged

Fix removing provider container error #235

merged 1 commit into from
May 21, 2024

Conversation

eemcmullan
Copy link
Collaborator

aufi
aufi approved these changes May 20, 2024
View reviewed changes
Copy link
Member

@aufi aufi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

pranavgaikwad
pranavgaikwad approved these changes May 20, 2024
View reviewed changes
Copy link
Contributor

@pranavgaikwad pranavgaikwad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks for catching this

@eemcmullan eemcmullan merged commit aa605e9 into konveyor:main May 21, 2024
3 checks passed
@eemcmullan eemcmullan deleted the rm-container branch May 23, 2024 17:55
@eemcmullan eemcmullan mentioned this pull request Jun 3, 2024
Closed
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pranavgaikwad pranavgaikwad pranavgaikwad approved these changes

@aufi aufi aufi approved these changes

@shawn-hurley shawn-hurley Awaiting requested review from shawn-hurley

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@eemcmullan @aufi @pranavgaikwad