🐛 Fix labels validation print

[aufi]

Fixing fmt.Fprintln to correctly recognize first argument as a writer buffer. Bug was introduced in my PR #243

This should fix kantra CI.

[aufi]

I believe the CI uses "previous" kantra image, that was reason it didn't fail on original PR and looks red on this PR.

Works with locally built image based on this PR.

[pranavgaikwad]

@aufi I don't think CI uses previous image, we build one in one of the steps unless I am missing something.

[pranavgaikwad]

I think we need to update the parsing logic to accomodate for weirdness in different shells (thinking about windows too). Can we just match a regex for label value format on every line of output https://github.com/konveyor/analyzer-lsp/blob/82b3f8b673cbfc178259faf6e35846bc0534d409/engine/labels/labels.go#L21

[aufi]

@aufi I don't think CI uses previous image, we build one in one of the steps unless I am missing something.

From what I can see locally, the RUNNER_IMG is not propagated to containers kantra executes

$ RUNNER_IMG=kantra-labels go run main.go  analyze --list-targets --log-level 99 # containers still use quay.io/...kantra

Will look on that to be sure I'm not wrong.

[aufi]

I think we need to update the parsing logic to accomodate for weirdness in different shells (thinking about windows too). Can we just match a regex for label value format on every line of output https://github.com/konveyor/analyzer-lsp/blob/82b3f8b673cbfc178259faf6e35846bc0534d409/engine/labels/labels.go#L21

Sounds good, just question what if a line would have more than one match of the regex? (fail I'd suggest)

[eemcmullan]

@pranavgaikwad I noticed the same issue as @aufi while I was debugging #247 where the listLabels command uses the current image at quay.io/konveyor/kantra:latest and not a fresh build of runnerImage. Although I built and set a new runnerImage, I had to override these values locally https://github.com/konveyor/kantra/blob/main/cmd/version.go#L11-L12 for it to finally work.

[pranavgaikwad]

@eemcmullan looks like this is always setting the default value?

kantra/cmd/settings.go

Lines 89 to 96 in 52f87d7

	img := strings.TrimSuffix(RunnerImage, fmt.Sprintf(":%v", Version))
	updatedImg := fmt.Sprintf("%v:%v", img, Version)
	err := os.Setenv("RUNNER_IMG", updatedImg)
	if err != nil {
	return err
	}
	return nil

Shouldn't user input values take precedence over defaults?

[aufi]

A quick friday-afternoon solution, will continue/follow-up on Monday. Seems the Config mechanism is not setup correctly.

[aufi]

This is problem affects more config options, submitted an issue #252 expecting it is a follow-up, but changing things unrelated to this PR.

[aufi]

There was a conflict with package-level variables from https://github.com/konveyor/kantra/blob/main/cmd/version.go#L12-L16 partially overlapping Settings fields names. Updated Settings to load env with tags (default) as the first step and adjusting it in custom methods as the second one (and use variables within the Settings struct, not outsite).